Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure mentions non-existant make command. #9

Closed
brtnfld opened this issue Dec 10, 2021 · 8 comments
Closed

configure mentions non-existant make command. #9

brtnfld opened this issue Dec 10, 2021 · 8 comments

Comments

@brtnfld
Copy link
Collaborator

brtnfld commented Dec 10, 2021

As far as I can tell there is no "ptest" for make:

./configure.ac:AC_ARG_VAR(TESTMPIRUN, [MPI run command for "make ptest", @<:@default: mpiexec -n NP@:>@])
./configure.ac:AC_ARG_VAR(TESTOUTDIR, [Output file directory for "make check" and "make ptest", @<:@default: ./@:>@])

@khou2020
Copy link
Collaborator

It is left for future extension and should not cause any problem in the build.

@wkliao
Copy link
Collaborator

wkliao commented Dec 10, 2021

@khou2020
Please comment out those 2 lines.
Once parallel test feature is added in the future, we will uncomment them.
Otherwise the configure help messages are misleading.

@brtnfld
Copy link
Collaborator Author

brtnfld commented Dec 10, 2021

I'm confused, aren't the tests in test/basic parallel (run with "make check")? Are they only meant to be run with one rank?

@wkliao
Copy link
Collaborator

wkliao commented Dec 10, 2021

Currently "make check" only run test program sequentially.
See file test/basic/wrap_runs.sh
We will add make target "ptest" soon.

@wkliao wkliao reopened this Dec 10, 2021
@brtnfld
Copy link
Collaborator Author

brtnfld commented Dec 10, 2021

hmm, I guess that is why it is segfaulting on summit. I could not get make check to pass there, so I had to run the tests manually.

I was just testing the install because my QMCPACK benchmark is segfaulting on summit with the VOL.

@khou2020
Copy link
Collaborator

It is commented out. Can you share your application that crashed logvol?

@khou2020
Copy link
Collaborator

hmm, I guess that is why it is segfaulting on summit. I could not get make check to pass there, so I had to run the tests manually.

I was just testing the install because my QMCPACK benchmark is segfaulting on summit with the VOL.

Can you share the QMCPACK benchmark? Also the way you build and ran it.

@khou2020
Copy link
Collaborator

Moved to issue 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants