Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HDF5 1.13.3 #45

Merged
merged 5 commits into from
Dec 7, 2022
Merged

Support HDF5 1.13.3 #45

merged 5 commits into from
Dec 7, 2022

Conversation

khou2020
Copy link
Collaborator

@khou2020 khou2020 commented Dec 4, 2022

Move data object creation to post open call.
Support VOL connector V3 used in HDF5 1.13.3.

@khou2020 khou2020 force-pushed the post_open branch 2 times, most recently from c18fba7 to 53985f8 Compare December 5, 2022 10:35
@khou2020 khou2020 requested a review from wkliao December 5, 2022 12:03
@wkliao
Copy link
Collaborator

wkliao commented Dec 5, 2022

Need an explanation of why testing Openpmd is removed.

@wkliao
Copy link
Collaborator

wkliao commented Dec 5, 2022

Has this PR been tested against HDF5 1.13.2?

@khou2020
Copy link
Collaborator Author

khou2020 commented Dec 5, 2022

Has this PR been tested against HDF5 1.13.2?

Zanhua tested on 1.13.2. I tested on 1.13.0 and 1.13.3.

@khou2020
Copy link
Collaborator Author

khou2020 commented Dec 5, 2022

Need an explanation of why testing Openpmd is removed.

The cache module used by OpenPMD is not compatible with the newest gcc used on git action.
It declares an array of size MINSIGSTKSZ. MINSIGSTKSZ was defined as a constant in older version but not anymore.
variable sized arrays are also removed in newer standard, so the code is rejected.
There is already a ticket about it.
catchorg/Catch2#2421

I can still run OpenPMD test using older compilers locally.
It is not tested in git action due to compiler version but stay as a configure option.

@wkliao
Copy link
Collaborator

wkliao commented Dec 5, 2022

Please create an issue at OpenPMD.
Then let's refer this issue in our release note.

@wkliao
Copy link
Collaborator

wkliao commented Dec 5, 2022

Please add a new workflow yaml file to test HDF5 1.13.2.

@khou2020
Copy link
Collaborator Author

khou2020 commented Dec 5, 2022

Please add a new workflow yaml file to test HDF5 1.13.2.

We are already using 1.13.2.
I added script to test 1.13.3.

@wkliao
Copy link
Collaborator

wkliao commented Dec 5, 2022

rename ubuntu_mpich_1.13.3.yml to hdf5_1.13.3.yml

@wkliao
Copy link
Collaborator

wkliao commented Dec 5, 2022

Because HDF5 1.13.3 is the latest, we should update all yaml file to use 1.13.3
and rename hdf5_1.13.3.yml to hdf5_1.13.2.yml to test 1.13.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants