Fix Shapefile Reader fail to handle UNDEFINED type #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuasu
approved these changes
Sep 8, 2018
jiayuasu
pushed a commit
that referenced
this pull request
Sep 9, 2018
* add condition for iterating when shape type is UNDEFINEd * compare Shapetype instead of directly int value * add test for UNDEFINED type * add test case
jiayuasu
pushed a commit
that referenced
this pull request
Sep 9, 2018
* add condition for iterating when shape type is UNDEFINEd * compare Shapetype instead of directly int value * add test for UNDEFINED type * add test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focus on solving issue #228
Why does this bug happen:
When we meet UNDEFINED shape type, I'll loop to find next shape that is of acceptable ShapeType, this loop doesn't check if there are next shape, so it will keep looping if after the UNDEFINED shape there is no more.
I've also added this shapefile into our test case.