Merge pull request #75 from DataValues/deadCode

Drop dead code from quantity classes

src/DataValues/QuantityValue.php

@@ -410,12 +410,6 @@ public function transform( $newUnit, $transformation ) {
 			throw new InvalidArgumentException( '$newUnit must not be empty. Use "1" as the unit for unit-less quantities.' );
 		}
 
-		$oldUnit = $this->unit;
-
-		if ( $newUnit === null ) {
-			$newUnit = $oldUnit;
-		}
-
 		// Apply transformation by calling the $transform callback.
 		// The first argument for the callback is the DataValue to transform. In addition,
 		// any extra arguments given for transform() are passed through.

src/ValueParsers/QuantityParser.php

@@ -188,10 +188,7 @@ private function splitQuantityString( $value ) {
 	 * @return QuantityValue
 	 */
 	private function newExactQuantity( DecimalValue $amount, $unit = '1' ) {
-		$lowerBound = $amount;
-		$upperBound = $amount;
-
-		return new QuantityValue( $amount, $unit, $upperBound, $lowerBound );
+		return new QuantityValue( $amount, $unit, $amount, $amount );
 	}
 
 	/**