Enforce minimal year padding to 4 digits #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine to me, |
| * Gregorian and Julian dates use the same YMD ordered format, resembling ISO 8601, e.g. | ||
| * +2013-01-01T00:00:00Z. In this format the year is always signed and padded with zero | ||
| * characters to have between 4 and 16 digits. Month and day can be zero, indicating they are | ||
| * unknown. The timezone suffix Z is meaningless and must be ignored. Use $timezone instead. |
There was a problem hiding this comment.
Still think we should use *, not 0, for unknown. Using 0 will break or confuse many parsers anyway, but it's not as obvious as using *.
There was a problem hiding this comment.
This discussion should not happen in this patch. Please open a ticket if you think this should change. However, I disagree. As @Jc3s5h pointed out the ISO norm does this by truncating the timestamp string. We do this with our "precision" field. Everything behind is meaningless and must be ignored. In the end it doesn't matter if month and day are "01", "00" or "**". I'm voting for "00".
adrianheine
added a commit
that referenced
this pull request
Mar 17, 2015
Enforce minimal year padding to 4 digits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements an enforced padding to 4 digits for the year. This is the most minimal compromise. Look at how the
DateTimeParseris implemented: It uses PHP's internal DateTime parser and needs to pad (and cut) the year to 4 digits to do this. An enforced padding to 4 digits is not crucial in this class but very convenient for almost all (external) use cases.We can easily increase this to 16 digits later, depending on the outcome of the discussion at T66084 and related Phabricator tasks.
This also adds a test to ensure more than 16 digits for the year are not accepted.
The 1st commit is crucial, the 2nd is only a style change.
Bug: T66084