-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dashboards] Implement support for Geomap Dashboard Widget #954
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, I left some inline comments, I don't think we should introduce a deprecated field on new widgets.
Otherwise, can you pull in the latest master branch? There are new CI additions for docs and linting that would be good to let run before we merge.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This pull request implements support for creating Geomap widgets in Dashboards.