Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize calling function with environment #12

Merged
merged 2 commits into from
Oct 24, 2016

Conversation

MichaReiser
Copy link
Owner

No description provided.

Micha Reiser added 2 commits October 24, 2016 12:30
1. The function wrapper should be defined directly inside of the extracted function. Otherwise the function might end in a loop and then might be instantiated for each loop
2. Do not use Array.slice as this prevents v8 from optimizing the function call.

The function is still quite slow if called often...
@MichaReiser MichaReiser force-pushed the optimize-calling-function-with-environment branch from b43eee4 to 62c816f Compare October 24, 2016 13:17
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 92.601% when pulling 62c816f on optimize-calling-function-with-environment into 60fd014 on master.

@MichaReiser MichaReiser merged commit 6470aeb into master Oct 24, 2016
@MichaReiser MichaReiser deleted the optimize-calling-function-with-environment branch October 24, 2016 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants