New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reafactored main structure #6

Merged

Dathin merged 4 commits into main from feat/main-refactor

Nov 9, 2021

Owner

Dathin commented Oct 25, 2021 •

edited

TODO:

Unit test whole code before merge
Ask neto about his opinion since he is mainly contributing to this repo
release new version
ensure it will pass qualitygate
fix any old qualitygate issue
sleep since it is 2 AM =)
Do not throw raw mojo exceptions since it is going to be encapsulated at the new Command class


          feat: reafactored main structure

1c68500

Dathin added the Wip label


          chore: update hooks

1af8225

Dathin mentioned this pull request

Adds HuskyInstall Component #2

Merged

Dathin added 2 commits

November 8, 2021 12:47


          fix: variables and stringformat

68f90e3


          fix: integration issues

0fc670e

sonarcloud bot commented Nov 8, 2021 •

edited

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

Dathin marked this pull request as ready for review

November 8, 2021 16:01

Owner Author

Dathin commented Nov 8, 2021 •

edited

Hey neto, I'll be merging this PR now so you can move on bringing it modular.

Also I was thinking about the unit tests, and how they would be very touch with file system, so I moved to integration tests only

Dathin merged commit 773b95c into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment