Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create procedure yaml re using procedure body not procedure text use procedure body #115

Conversation

ldeck
Copy link
Contributor

@ldeck ldeck commented Apr 14, 2021

This pull request primarily updates the documentation for createProcedure.

  1. It fixes the sample code for yaml, using procedureBody instead of procedureText, which doesn't work for yaml as per https://liquibase.jira.com/browse/CORE-1847.
  2. It fixes the indentation of xml, yaml and json sample code blocks.

I initially raised a discussion to ask why the original issue had been closed as "By design" but thought it'll be more helpful to just update the docs to enable others to find the answer quickly and officially.

Copy link
Contributor

@nmelny nmelny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ldeck, thank you very much for your PR, it is approved.

@nmelny nmelny merged commit d044541 into liquibase:master Apr 23, 2021
@ldeck ldeck deleted the fix-createProcedure-yaml-re-using-procedureBody-not-procedureText-use-procedureBody branch April 23, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants