Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skill tree doesn't show up any more #25

Closed
Pangaea666 opened this issue Jan 16, 2024 · 10 comments
Closed

Skill tree doesn't show up any more #25

Pangaea666 opened this issue Jan 16, 2024 · 10 comments

Comments

@Pangaea666
Copy link

Am unsure when this started happening, but it worked before and now the skill tree no longer shows up. I'm on Firefox on PC/Linux. It works on mobile, where I also use Firefox. Have tried to disable extensions like Privacy Badger and uBlock Origin, but the tree still doesn't show up, so I'm not sure what is the cause of this. The keynodes and masteries show up in the right panel, but not the skill tree selection.

As an aside, the level listed is and skill points count is wrong, maybe due to the 2nd ascendancy tree we have now? The screenshot is with a level 92 character, yet it shows up as 99 in Pobb.in.

https://pobb.in/E_baMWebo_JQ
Pobbin missing skill tree

@Dav1dde
Copy link
Owner

Dav1dde commented Jan 16, 2024

Can you try clearing your browser cache, I assume you have an old version of pobbin cached locally but an updated version of the tree.

If that does not help, please open the dev tools (F12) and check bottom right/console for any errors.

As an aside, the level listed is and skill points count is wrong, maybe due to the 2nd ascendancy tree we have now? The screenshot is with a level 92 character, yet it shows up as 99 in Pobb.in.

Good catch, this is likely what is happening!

@Pangaea666
Copy link
Author

Can you try clearing your browser cache, I assume you have an old version of pobbin cached locally but an updated version of the tree.

Tried to clear it a few times, both via the 'keylock' for the site itself, and then globally via settings. Restarted Firefox too, but the skill tree still doesn't show up. It's odd, because I haven't changed anything, and it used to work before, and does work on my phone. Tried to disable all extensions, but that didn't do the trick either.

Am not familiar with that part of the dev tools, so let me know if I'm looking at the wrong parts. This is what shows up:

Screenshot from 2024-01-16 18-10-32

@Dav1dde
Copy link
Owner

Dav1dde commented Jan 16, 2024

Thanks, this is weird you at least have the latest wasm and javascript files.

Can you try enabling this:
image

Go to network then check disable cache (as in the screenshot), with the dev tools open and that box ticked, reload the page and then see if something shows up in the console again.

Also does this happen on every build or just this one? E.g. try opening this one: https://pobb.in/zT6XR9maky9m

@Pangaea666
Copy link
Author

Thanks for the instruction. The log is attached. A lot if fetched, but some assets appear to be blocked.

This happens on every build btw, not just the one from the first post. Any time I open up a build from reddit, discord servers or PoB, they never show up with the skill tree visible.

Tried turning off all extensions again and reload the page. Skill tree doesn't show up then either, but fewer assets are blocked. But 3.23.svg is still blocked according to the log.

Screenshot from 2024-01-19 08-53-22

@Dav1dde
Copy link
Owner

Dav1dde commented Jan 19, 2024

Do you have a plugin called CanvasBlocker installed? If not can you click on iframeProtection.js in the network log (Initiator column) and screenshot where it takes you?

@Pangaea666
Copy link
Author

Sorry for late feedback again. Wasn't busy playing the game. Promise! :D

I do indeed have CanvasBlocker installed. However, even when I disabled all extensions, including CanvasBlocker, the skill tree still failed to show up. But since you mention that one specifically, maybe it is at fault for blocking the lines shown in the screenshot. With everything off, it was "only" the 3.23.svg that was blocked.

@Dav1dde
Copy link
Owner

Dav1dde commented Jan 23, 2024

I assume it's some privacy extension or firefox setting blocking access to the tree object/iframe.

Can you run document.getElementsByTagName('object')[0].contentWindow.tree_load in the dev tools console and see what get's returned? It should look like this:
image

The errors in the network tab are actually fine, this is just some weird interaction with pre loading where the same resource gets requested multiple times and the first requests are aborted in favor of the latest.

Also feel free to reach out to me dav1d on the official poe discord in the #tooldev-general channel.

@Pangaea666
Copy link
Author

Hopefully I did this right, by copying what you wrote at the bottom of the Console in Dev Tools. Tested it with CanvasBlocker both enabled and disabled, but it yields the same message.

canvasblockerOFF

What I find a little odd is that I've used this set of extensions all the time, and previously the skill tree used fine. But ofc it's possible there has been an update to one of them, or even CanvasBlocker, or Firefox itself, that means the skill tree no longer shows up. Unless something has changed on pobb.in's side ofc.

@Dav1dde
Copy link
Owner

Dav1dde commented Jan 25, 2024

Something is blocking access to the contentWindow (basically the tree SVG).

It doesnt seem to be Canvas Blocker, since even with it enabled on my Firefox it works. Maybe some privacy setting changed in about:config or a (misconfigured) extension.

Not sure how to further debug this, you can try in incognito (that usually disables extensions) or with a fresh install/profile.

@Dav1dde
Copy link
Owner

Dav1dde commented Feb 11, 2024

The levels are now correct if all ascendancy passives are allocated, fixing it properly does require game data which I currently don't have available, will fix that eventually.

Regarding your issues feel free to reach out on discord.

@Dav1dde Dav1dde closed this as completed Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants