Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Tree preview does not work on tablets #9

Closed
chasebrewsky opened this issue Mar 26, 2023 · 6 comments
Closed

Bug: Tree preview does not work on tablets #9

chasebrewsky opened this issue Mar 26, 2023 · 6 comments

Comments

@chasebrewsky
Copy link

Example PoB: https://pobb.in/MqBwqqTLVBhW

I tried viewing the passive tree for this PoB on an iPad mini, but the nodes were not highlighted. It just showed a greyed out tree. I tested this out on Chrome + Firefox + Safari on the iPad mini. It cannot be replicated by using the responsive testing features of chrome or firefox dev tools, only through a tablet. It does not occur on mobile.

@chasebrewsky
Copy link
Author

This may be an issue related to iOS since my mobile phone is an android.

@Dav1dde
Copy link
Owner

Dav1dde commented Mar 26, 2023

What Safari version do you have on the ipad? Can you check if it works on a mac book?

On iOS all browsers use the same engine iirc so it's not surprising all browser don't work. I assume it simply does not support the required SVG 2 features (styling nodes with CSS).

@chasebrewsky
Copy link
Author

It's running iPadOS 16.3.1, so safari 16. I'm checking this on a macbook right now and it works here.

Now that I'm looking closely at it, it does look like the lines for the path exist on the iPad but are just not colored correctly. I see that stroke="currentColor" is set on the parent g element and each line or path that should be highlighted that color has their CSS color=#colornum. I'm curious if in iOS it doesn't cascade the parents stroke property and expects an explicit attribute set on each element.

@chasebrewsky
Copy link
Author

Nope, just read that the g element is supposed to cascade attributes to children.

@chasebrewsky
Copy link
Author

You're probably right that it's just iOS being behind the times on the spec. That's a shame.

@Dav1dde
Copy link
Owner

Dav1dde commented Mar 26, 2023

I would like to support it, but they make it incredibly hard (basically impossible) to test without getting a mac book and a mobile device/ipad :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants