Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom store name not used for aggregations #16

Closed
wkf opened this issue Feb 18, 2021 · 2 comments
Closed

Custom store name not used for aggregations #16

wkf opened this issue Feb 18, 2021 · 2 comments

Comments

@wkf
Copy link

wkf commented Feb 18, 2021

Hello! Thanks for the library.

I noticed that the recently added custom store-name key is not used if an :aggregate-adder-fn is also defined. Is this working as intended?

Also, the key name mentioned in the issue for the original PR mentions :willa.core/store-name, but tE code seems to use :willa.streams/store.name, is that right?

@DaveWM
Copy link
Owner

DaveWM commented Feb 25, 2021

Hey, thanks very much for raising this issue, those are definitely bugs! I've just pushed version 0.2.1 which should fix both problems.

@DaveWM DaveWM closed this as completed Feb 25, 2021
@wkf
Copy link
Author

wkf commented Feb 25, 2021

thanks @DaveWM, I really appreciate you taking a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants