Awesome books: with ES6 #1
Conversation
There was a problem hiding this comment.
Hi @David-Kasilia,
Highlights
✔️ Descriptive PR
✔️ Passing linters
✔️ Arrow functions
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻️
Check the comments under the review.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
modules/storebooks.js
Outdated
|
|
||
| static removeBook(title) { | ||
| const books = StoreBooks.getBooks(); | ||
|
|
||
| books.forEach((book, index) => { | ||
| if (book.title === title) { | ||
| books.splice(index, 1); | ||
| } | ||
| }); | ||
|
|
||
| localStorage.setItem('books', JSON.stringify(books)); | ||
| } | ||
| } |
There was a problem hiding this comment.
-
Your app does not really clear the local storage on removing the books. When I remove books and reload all the books still come back on the page. Kindly fix this.
books are added books are removed Page is refreshed 
There was a problem hiding this comment.
Thank You for your Review I have Fixed the issue.
There was a problem hiding this comment.
Hi @David-Kasilia ,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
- Descriptive Pull Request ✔️
- Good use of gitflow ✔️
- Clean code ✔️
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me (@codecaiine) in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
To Highlight