Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content to home page #25

Merged
merged 1 commit into from Aug 31, 2022
Merged

Add content to home page #25

merged 1 commit into from Aug 31, 2022

Conversation

David-Kasilia
Copy link
Owner

@David-Kasilia David-Kasilia commented Aug 31, 2022

To Highlight

  • Created the main part of the homepage that keeps the layout from the wireframe
  • Used the pokeApi to implement this task
  • Fixed linters errors
  • Prepared the comments button

@David-Kasilia David-Kasilia linked an issue Aug 31, 2022 that may be closed by this pull request
Copy link
Collaborator

@HabibPayenda HabibPayenda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @David-Kasilia,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • No linter errors. ✔️
  • Gitflow is followed. ✔️
  • PR has a good title and summary. ✔️

Cheers and Happy coding!👏👏👏

@David-Kasilia David-Kasilia merged commit e11684e into develop Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[4pt] - Display list of items on the Homepage - Student A
2 participants