Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds comments pop-up: #26

Merged
merged 1 commit into from Aug 31, 2022
Merged

Adds comments pop-up: #26

merged 1 commit into from Aug 31, 2022

Conversation

HabibPayenda
Copy link
Collaborator

The following requirements were implemented:

  • Add comments pop-up.
  • Get the data from the Api based on the clicked item.

Please check if I have missed something.

Thanks!

Copy link
Owner

@David-Kasilia David-Kasilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @HabibPayenda

I am Your coding partner @David-Kasilia. I am reviewing your PR.
Your project is complete! There is nothing else to say other than... it's time to merge it. 💯
Congratulations! 🥳 🎉

Highlights

  • Great job setting up the correct linters ✔️
  • Correct workflow ✔️
  • Meaningful commit messages ✔️
  • Great job on implementing the comments popup correctly ✔️

Great Work @HabibPayenda 👏👏👏
Cheers and Happy coding!👏👏👏

@HabibPayenda HabibPayenda merged commit 286d658 into develop Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[4pt] -Display Comments pop up with selected item's details - Student B
2 participants