Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math Magician Full Website #5

Merged
merged 2 commits into from Sep 13, 2022
Merged

Math Magician Full Website #5

merged 2 commits into from Sep 13, 2022

Conversation

David-Kasilia
Copy link
Owner

To Highlight

  • Created Home Calculator and Quote component files
  • Implemented Rerouting and tested
  • Implemented React Basic Styling i.e importing CSS to App.js
  • Changed Title for the page

Copy link

@Nemwel-Boniface Nemwel-Boniface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @David-Kasilia 👋 ,

I am Nemwel your reviewer for this PR 🧔‍♂️

Thank you for meeting all the project requirements good job! 🥳
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🥳 🎉

Highlights

Great job setting up the correct linters ✔️
Professional documentation ✔️
Correct workflow ✔️
Meaningful commit messages ✔️
Met all the milestone requirements ✔️

[Optional] suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @Nemwel-Boniface in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@David-Kasilia David-Kasilia merged commit a90b7b1 into develop Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants