Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.12 Test failing due to change in FunctionDef creation - Should be fixed in 3.12.0-beta2 #67

Closed
DavidCEllis opened this issue Jun 7, 2023 · 2 comments
Closed

3.12 Test failing due to change in FunctionDef creation - Should be fixed in 3.12.0-beta2 #67

DavidCEllis opened this issue Jun 7, 2023 · 2 comments

Comments

@DavidCEllis
Copy link
Owner

Changes related to typing syntax added a field you need to create a functiondef correctly so all of the AST based implementation tests are failing on 3.12. It looks like this has already been patched to now just create an empty list.

python/cpython#104834

This issue is just to note to retest once beta 2 is available on github actions.
@DavidCEllis
Copy link
Owner Author

Seems to still be broken in 3.12.0-beta2 - But only in unparsing? Need to investigate.

@DavidCEllis
Copy link
Owner Author

Passes now after beta3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DavidCEllis