Timeouts of a second lock waiting for a first lock to yield

[naddison36]

Thanks for open sourcing this library. It's very close to what I've been looking for.

In the below test I have the first lock holding for 6 seconds while the second lock only has a 3 second timeout. After six seconds of waiting, the second lock yields and continues on with no error but does not have the lock. This doesn't seem right to me. I would have expected either:

1. The second lock is held for three seconds after it yields
2. The second lock throws an error as it was unable to get the lock in the 3 second timeout period

it('timeout waiting for a lock', function * () {
      yield client.lock('node_lock_test_8', 6000)
      yield client.lock('node_lock_test_8', 3000)

      let isLocked = yield client.isLocked('node_lock_test_8')
      assert(isLocked === true)
    })
  })

Note the following test passes but the second lock is only held for 1 second and not 7 from when it yields.

it('timeout waiting for a lock', function * () {
      yield client.lock('node_lock_test_8', 6000)
      yield client.lock('node_lock_test_8', 7000)

      let isLocked = yield client.isLocked('node_lock_test_8')
      assert(isLocked === true)
    })
  })

[naddison36]

I think this is more an issue with etcd's locking solution than this library. I've raise etcd-io/etcd#9921