Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load EditDialog component #205

Open
DavidGolodetsky opened this issue Oct 29, 2021 · 1 comment
Open

Lazy load EditDialog component #205

DavidGolodetsky opened this issue Oct 29, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects

Comments

@DavidGolodetsky
Copy link
Owner

DavidGolodetsky commented Oct 29, 2021

Actual: On the Games and Game pages we have an edit action. When it's clicked an EditDialog is opened. But the dialog is loaded with the whole page, even if the user doesn't want to edit anything.

image

Expected: Only when user clicks the edit action the EditDialog would load.

Tech notes: You can check the desired behaviour if you'll place a v-if directive on the actions slot. Then once it's truthy the component will be fetched via dynamic imports.
You can also make use of webpack magic comments to identify a chunk.
GamesEditDialog: () => import(/* webpackChunkName: 'GamesEditDialog' */ '@/components/GamesEditDialog.vue')

@DavidGolodetsky DavidGolodetsky added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 29, 2021
@DavidGolodetsky DavidGolodetsky added this to To do in GeekScore Oct 29, 2021
@alexjharrison
Copy link

I'd like to be assigned this issue. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
GeekScore
Backlog
Development

No branches or pull requests

2 participants