New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: allow restricting accessible IPs #13
Comments
I think it makes sense to allow all connections through by default, i.e. let it work as a server and expose the client to any targets when CONNECT-UDP is in listener mode. Besides, if people deem that permissions need to be built, it could be done through a separate extension. |
If you want to address this in this draft, you could add a "whitelist" and "blacklist" to the request. These fields would be mutually exclusive, and would contain a list of IP addresses (and ports, maybe?). That said, I don't have use case for either of them, so I'd be fine with punting it to a future extension. |
I agree, we don't have a use case for these permissions either. Since it would be straightforward to build this as a future extension, I'm inclined to not incorporate the feature. |
Tommy's idea of adding the option to block uncompressed connections may be sufficient to do this, see my latest update to the PR |
From Benjamin Schwartz on the list and also Peter Thatcher on the list:
The text was updated successfully, but these errors were encountered: