Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native node.js crypto vs aes-js #27

Closed
mvayngrib opened this issue May 22, 2018 · 5 comments
Closed

native node.js crypto vs aes-js #27

mvayngrib opened this issue May 22, 2018 · 5 comments

Comments

@mvayngrib
Copy link

thanks for making this port!

is there any reason you chose to use aes-js instead of node.js crypto? You'll get better performance with native, and if you want to support the browser, you don't need to do anything special as browserify/webpack will plug in crypto-browserify automatically

@DavidTanner
Copy link
Owner

You are welcome to add a pull request that switches it out.

@mvayngrib
Copy link
Author

@DavidTanner cool, one of these days. I forked and got a bit carried away: https://github.com/tradle/credstash (s3 backend support, CLI, and some general refactoring)

@DavidTanner
Copy link
Owner

I have a CLI in a separate repo. Mostly this needs to fit the requirements set in the main credstash application.

@DavidTanner
Copy link
Owner

@mvayngrib
Copy link
Author

cool, makes sense to separate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants