-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ListBox (Select) doesn't scroll when using keyboard arrows #52
Comments
Hey @DavidVollmers are you working on this or could I give it a try? I implemented a search just like html |
Hey there! Feel free to give it a try, although the scroll implementation will be a little bit tricky here. The keydown logic is implemented here:
But I think the best way to solve this issue is to overwrite the
|
We should fix this for all popups though. This means we should implement it in a way we can reuse the logic for the |
I see, I will give it a try with that in mind! |
This is fixed with release 1.4.0 |
Hey, as I was trying the ListBox with a lot of items I noticed that the keyboard doesn't scroll the list. The items get's selected etc but you can't actually see it.
Actual behavior
![msedge_6](https://private-user-images.githubusercontent.com/20771798/320092933-a6035136-f2bf-43f8-8e38-8af127645689.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk0MjgyNjUsIm5iZiI6MTcxOTQyNzk2NSwicGF0aCI6Ii8yMDc3MTc5OC8zMjAwOTI5MzMtYTYwMzUxMzYtZjJiZi00M2Y4LThlMzgtOGFmMTI3NjQ1Njg5LmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI2VDE4NTI0NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQxOWQ5ZThkZmJjNWNmOWZjOWFjODkzZDY3Njc4ZTNhMTM2Y2YyZDkxMGFlOWMxMWEzMmQzMGUzNWVlYzU2YTcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.aDeObjb0cviZ_EHNp-qir0WIM9w2b_7u81BElXdC94g)
Expected behavior (from official library)
![msedge_4](https://private-user-images.githubusercontent.com/20771798/320092838-3ca95751-ff0b-4861-b84a-532d230147b3.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk0MjgyNjUsIm5iZiI6MTcxOTQyNzk2NSwicGF0aCI6Ii8yMDc3MTc5OC8zMjAwOTI4MzgtM2NhOTU3NTEtZmYwYi00ODYxLWI4NGEtNTMyZDIzMDE0N2IzLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI2VDE4NTI0NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEwZmM2ZTFiZDdkNmU3NTFkOTdlMmQzZjJjN2ZmN2FlMGJjY2MxZmZjNDNmZjVmZTQzYTgxMThlYzJiYjI3ZDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.bHh3wU9LFCU1f70YlTBrWAtw476h53Vy7Nopg_hwEYs)
The text was updated successfully, but these errors were encountered: