Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upper limit for flexiplex_filter #24

Open
nadiadavidson opened this issue Oct 6, 2023 · 2 comments
Open

Upper limit for flexiplex_filter #24

nadiadavidson opened this issue Oct 6, 2023 · 2 comments

Comments

@nadiadavidson
Copy link
Contributor

@olliecheng First instance of the filter selecting the wrong rank. See figures below. First in default setting, second is shifting the upper limit to 12000.

Figure_1
Figure_2

@nadiadavidson
Copy link
Contributor Author

It switched the order of the images on upload, so first image with this custom upper limit and second the default.

@olliecheng
Copy link
Member

olliecheng commented Oct 6, 2023

At the moment the default lower bound is the 0.95 quantile (code). Admittedly I just eyeballed this value because it looks 'about right' with my sample datasets, but it seems to be a bit too strict at times.

A couple of alternative ideas

  • BLAZE uses the value of the 0.95 quantile, divided by 20
  • BLAZE also includes a 'high sensitivity' setting which uses c0.95 divided by 200. Might be good to include such a flag for those stubborn datasets as an easy fix
  • A possibly more reliable approach could look for this region, which tends to correlate to bad reads which should be discarded. These are indicated by regions with hundreds/thousands of reads which all have the same, low count (usually something like <1).
    image

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants