#55 keyboard shortcuts #57
Conversation
|
Yeah, regular CTRL+arrow key behavior, jump all the way to the end. I also wanted to see it on the main menu screen, so we'd be jumping left and right too. Github default for the auto lint for new contributors seems to have been on an approval basis, I've gone in and changed the setting so first time commits don't have to wait anymore, but now that it has it seems like there's a few lines that the lint wants a little bit more elaboration on. You can run |
skunkbooth/main.py
Outdated
| @@ -28,6 +29,17 @@ | |||
| ) | |||
|
|
|||
|
|
|||
| def global_shortcuts(event): | |||
| """Event handler for global shortcuts""" | |||
| ctrlQCode = 17 | |||
There was a problem hiding this comment.
Where possible, we probably want to import and use the named variable in the enumeration from asciimatics instead of set keycodes as rigid numbers because asciimatics might change the keycode internally
There was a problem hiding this comment.
Commit dbc3f42 should have fixed this. I swapped the hard-coded values for the Screen.ctrl() function
skunkbooth/main.py
Outdated
| screen.set_scenes(scenes) | ||
| screen.set_scenes(scenes, unhandled_input=global_shortcuts) | ||
|
|
||
| if screen.current_scene == scenes[2]: |
There was a problem hiding this comment.
We want code specific to a screen to be in the screen's file instead of main.py.
There was a problem hiding this comment.
Commit 7efeeba should have fixed this. Instead of writing the code directly in main.py, I overrode the process_event method for the Filter Frame class so it would handle the navigational shortcuts required.
skunkbooth/main.py
Outdated
| fFrame.switch_focus(layout, 0, 0) | ||
| elif c == screen.KEY_END: | ||
| fFrame.switch_focus(layout, 0, len(fFrame.filterList)-1) | ||
| elif c == screen.KEY_PAGE_UP: |
There was a problem hiding this comment.
pgup and pgdown usually move by more than one arrow keypress, would be a full page but we don't have enough filters to page that far currently
There was a problem hiding this comment.
In commit 7efeeba, I created an empty function _skip_to_next_page with no implementation (pass) but which would contain this logic further down the line. Is this ok for now, or should I somehow emulate the pgup and pgdown navigation with the current set of filters?
There was a problem hiding this comment.
eh yeah sure this'll do for now, don't have enough filters to make this that relevant yet, we can make another easy ticket out of this
|
Gave it a spin and it works well enough, merging. |
Fixes #55
I have added the global shortcut bindings to close the application (q, esc, ctrl+w and ctrl+q) as well as the navigational shortcuts for the filter screen (pgUp, pgDown, Home, End).
However, I am not sure how the ctrl+arrow keys shortcut should behave from the issue description. Should they behave similarly to the home and end keys in the filter screen? If you could please clarify this point, I'd be happy to go in and implement that final shortcut too. I hope everything else is right and up to standard :)