Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up main.py #61

Open
Davidy22 opened this issue Aug 4, 2021 · 13 comments
Open

Clean up main.py #61

Davidy22 opened this issue Aug 4, 2021 · 13 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Davidy22
Copy link
Owner

Davidy22 commented Aug 4, 2021

main.py has become a bit of a dumping ground, clean it up a little bit by moving what should be moved out into other files.

@Davidy22 Davidy22 added enhancement New feature or request good first issue Good for newcomers labels Aug 4, 2021
@Arnab1181412
Copy link

Hey I want to fix this issue im new to github contributor and have good knowledge of python and can you give some context to it

@rashidkalwar
Copy link

rashidkalwar commented Aug 4, 2021

yeah I can see, it is a bit mess in there, I can help solving it, assign it to me, I will make a PR as soon as I can.

@Davidy22
Copy link
Owner Author

Davidy22 commented Aug 5, 2021

Oh whoops, github scrolled me to the bottom so I only saw rashid before I assigned. Well, there's another similar ticket so I can assign that one to arnab

@rashidkalwar
Copy link

hey @Davidy22
I made some changes and then made a pull request but I saw in the post commit their were some spacing and indentation issues, I checked and fixed all, still facing errors, please have a look where am I messing wrong.

@rashidkalwar
Copy link

sorry for all that mess with commits

@Davidy22
Copy link
Owner Author

Davidy22 commented Aug 5, 2021

You can run pre-commit install on the top level directory to install hooks that'll check your code on your machine and tell you what lines need checking.

@rashidkalwar
Copy link

@Davidy22
just closed the last PR, and made a new one this time looks great, please have a look and let me know.

@rashidkalwar
Copy link

@Davidy22 I am having a hard time understanding it and honestly I don't know what can mess wrong, since you have the access to make changes to my Pull Request, please modifying it so it doesn't crash anything.

@Davidy22
Copy link
Owner Author

Davidy22 commented Aug 7, 2021

I can take a look later after I get some stuff I wanted to clear done, but this should just be a matter of passing a reference to the buffer into the function.

@Davidy22
Copy link
Owner Author

Still busy with my stuff but it seems like rashid's having trouble with this, I'll assign both of you to this since I think github hasn't pinged arnab for the other ticket I mentioned him in, you can try fix up rashid's attempt or start from scratch.

@Davidy22
Copy link
Owner Author

Davidy22 commented Oct 9, 2021

Unassigning the two of you since it doesn't seem like this is going to get done.

@bhanu0002
Copy link

main.py has become a bit of a dumping ground, clean it up a little bit by moving what should be moved out into other files.

Hey. since no one is doing anything about it, I want a chance to do some clearing.
It will be my first commit after quite a while.

Thank you.

@Davidy22
Copy link
Owner Author

Sure, make the PR and I'll check it to make sure it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants