Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Overflow Bugs & Updated To 2.5.2 #12

Merged
merged 5 commits into from Oct 25, 2021
Merged

Fixed Overflow Bugs & Updated To 2.5.2 #12

merged 5 commits into from Oct 25, 2021

Conversation

Abdusin
Copy link
Contributor

@Abdusin Abdusin commented Oct 9, 2021

  • Get page route functions updated
  • fixed infos
  • updated to 2.5.2
  • fixed overflow errors

Davies-K
Davies-K reviewed Oct 12, 2021
View reviewed changes
Copy link
Owner

@Davies-K Davies-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. upon changing the get route implementation, some of the page routes are not working in flutter versions lower than 2.5. I personally tested on 2.2.3.

  2. Kindly check the implementation of the bottom sheet as it conflicts with the height in the designs. If there are overflow issues with the bottom sheet, kindly wrap the list of widgets in Expanded(child: ListView: (children[...widget]))

  3. Again you changed the status bar color for the splash screen, which was wrong. Please find attached screenshots. The color of the text in the status bar should be white.
    status_bar_2
    status_bar_color

lib/BottomSheets/bottom_sheets.dart Outdated Show resolved Hide resolved
lib/Screens/Auth/new_workspace.dart Outdated Show resolved Hide resolved
lib/Screens/Dashboard/timeline.dart Outdated Show resolved Hide resolved
lib/Screens/Dashboard/timeline.dart Outdated Show resolved Hide resolved
lib/widgets/BottomSheets/dashboard_settings_sheet.dart Show resolved Hide resolved
@Abdusin
Bottom Sheet System Update & Other Changes
128900f 
- now bottom sheets working dynamic
- system brigtness setted to default 'light'
- fixed overflow error
@Abdusin
Copy link
Contributor Author

Abdusin commented Oct 20, 2021

@Davies-K I hope I developed as you expected.

@Abdusin
Copy link
Contributor Author

Abdusin commented Oct 20, 2021

I did not withdraw the flutter version, because usage is always important in the last stable version.

@Davies-K
Copy link
Owner

@Abdusin noted !!! Will test and revert.

@Abdusin
Copy link
Contributor Author

Abdusin commented Oct 21, 2021

@Davies-K Can you check it ?

Davies-K
Davies-K approved these changes Oct 25, 2021
View reviewed changes
Copy link
Owner

@Davies-K Davies-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job Abdusin 🔥. I will add some spacing to the marketing details bottom sheet as it touches the bottom of the screen. Also the bottom sheet for addsettings has a lot of padding which I will resolve

@Davies-K Davies-K merged commit edc9513 into Davies-K:main Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Davies-K Davies-K Davies-K approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Abdusin @Davies-K