Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-validate="true" is getting added to buttons #399

Closed
fgrehm opened this issue Oct 8, 2012 · 3 comments
Closed

data-validate="true" is getting added to buttons #399

fgrehm opened this issue Oct 8, 2012 · 3 comments

Comments

@fgrehm
Copy link
Contributor

fgrehm commented Oct 8, 2012

I've just upgraded to 3.2.0.rc.2 and because of this and this I'm starting to have <button>s with data-validate=true

That represented a problem to me as I wasnt assigning a name for those buttons and an exception is raised half way through validations because of this.

As I workaround I've added the name attribute to all submit buttons and things got back working. It wasnt a big deal to me as I only had 2 forms with client side validations enabled but it might have a huge impact for others.

According to jQuery docs, the :input selector will select ALL form elements, including buttons and I believe that is not the desired behavior to have validations on buttons.

Thoughts?

@bcardarella
Copy link
Contributor

Doh! Thank you for the bug report, I'll fix ASAP

@bcardarella
Copy link
Contributor

Ok, give 3-2-stable a shot.

@fgrehm
Copy link
Contributor Author

fgrehm commented Oct 9, 2012

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants