Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All fields for student dashboard #11

Merged
merged 13 commits into from Feb 14, 2017
Merged

All fields for student dashboard #11

merged 13 commits into from Feb 14, 2017

Conversation

DawnPaladin
Copy link
Owner

No description provided.

@DawnPaladin DawnPaladin changed the title Finish student dashboard All fields for student dashboard Feb 14, 2017
def friendly_date
if self.term == "ANY"
self.year.to_s
else
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation logic. Should be moved to helpers

has_many :enrollments
has_many :scheduled_classes, through: :enrollments,
class_name: 'Meeting'

belongs_to :degree

def courses
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is get nil errors without checks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the thesis track function below this code capture

Copy link
Collaborator

@PopularDemand PopularDemand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments above!

Copy link
Collaborator

@PopularDemand PopularDemand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a todo about edge case coverage, but I think that works well for our seeds.

Copy link
Collaborator

@PopularDemand PopularDemand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. 👍

@PopularDemand PopularDemand merged commit 906d196 into master Feb 14, 2017
@luke-schleicher luke-schleicher deleted the student-dashboard branch February 15, 2017 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants