New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All fields for student dashboard #11
Conversation
app/models/meeting.rb
Outdated
def friendly_date | ||
if self.term == "ANY" | ||
self.year.to_s | ||
else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presentation logic. Should be moved to helpers
app/models/plan.rb
Outdated
has_many :enrollments | ||
has_many :scheduled_classes, through: :enrollments, | ||
class_name: 'Meeting' | ||
|
||
belongs_to :degree | ||
|
||
def courses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is get nil
errors without checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the thesis track
function below this code capture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments above!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a todo about edge case coverage, but I think that works well for our seeds.
…e-planner into student-dashboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. 👍
No description provided.