Improve event matching #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e required-events vector
hipitihop
approved these changes
Jun 19, 2017
src/day8/re_frame/async_flow_fx.cljs
Outdated
| @@ -8,7 +8,7 @@ | |||
| "Dissociates an entry from a nested associative structure returning a new | |||
| nested structure. keys is a sequence of keys. Any empty maps that result | |||
| will not be present in the new structure. | |||
| The key thing is that 'm' remains identical? to istelf if the path was never present" | |||
| The key thing is that 'm' remains identical? to iself if the path was never present" | |||
There was a problem hiding this comment.
Still misspelled comment iself
danielcompton
suggested changes
Jun 19, 2017
src/day8/re_frame/async_flow_fx.cljs
Outdated
| will either | ||
| - match only the event-keyword if a keyword is supplied | ||
| - match the entire event vector if a collection is supplied | ||
| - returns a the item itself if a fn is supplied" |
There was a problem hiding this comment.
returns callback-pred if it is a fn
src/day8/re_frame/async_flow_fx.cljs
Outdated
| (defn seen-all-of? | ||
| [required-events seen-events] | ||
| (empty? (set/difference required-events seen-events))) | ||
| (every? | ||
| (fn [pred] (some (fn [e] (pred e)) seen-events)) |
There was a problem hiding this comment.
Can (some (fn [e] (pred e)) seen-events) be written as (some pred seen-events)?
There was a problem hiding this comment.
I think every-pred might be better still here?
There was a problem hiding this comment.
every-pred? sadly won't work as the preds are applied in the inner fn.
src/day8/re_frame/async_flow_fx.cljs
Outdated
|
|
||
|
|
||
| (defn seen-any-of? | ||
| [required-events seen-events] | ||
| (some? (seq (set/intersection seen-events required-events)))) | ||
| (some? (some | ||
| (fn [pred] (some (fn [e] (pred e)) seen-events)) |
There was a problem hiding this comment.
Can (some (fn [e] (pred e)) seen-events) be written as (some pred seen-events)? Perhaps it would also be easier to read if it was extracted into a let binding as any-pred?
stumitchell
force-pushed
the
pr-improved-event-matching
branch
from
c7c6c7f
to
53bc6d1
Compare
danielcompton
approved these changes
Jun 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve event matching by allowing event vectors and predicates in the required-events vector.
In day8 internal code some things that currently can't be handled by an async flow will be possible with these changes.
In this pr I attempt to address some of the comments in #6 but do it in a different way and do not cover all of the use cases.
In particular, the
event-id->seen-fnis now handled by providing predicate fn's as used elsewhere in re-frame