fix bug in subscribe with reactive arguments #297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinklepsch
force-pushed
the
fix/296
branch
from
11739e8
to
3672d8f
Compare
danielcompton
added a commit
that referenced
this pull request
Dec 19, 2016
Fixes #296. Thanks to @martinklepsch for #297.
|
Thanks for this. I fixed it myself as I wanted to clean up all the indentation in the subs file at the same time and add some tests. Appreciate your help in diagnosing the problem though :) |
|
Sure no worries, indentation in that file needed some indentation-love anyways :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm inclined to blame this on an editor :D In general the indentation in that namespace seems a bit inconsistent.
/via #296