Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declaring collision bones in vertex shape removes tag collisions #78

Open
webspam opened this issue Jan 28, 2023 · 2 comments
Open

Declaring collision bones in vertex shape removes tag collisions #78

webspam opened this issue Jan 28, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@webspam
Copy link

webspam commented Jan 28, 2023

Describe the bug
Using bone collisions in per-vertex-shape results in can-collide-with-tag being overridden. Potentially affects triangle shapes, but not tested.

To Reproduce

  1. Create a per-vertex-shape
  2. Add a can-collide-with-tag to a per-triangle-shape with a tag set
  3. Collision works as expected
  4. Add a can-collide-with-bone to any bone
  5. Collision with the bone now works, however collision with tag does not occur

Expected behavior
Adding can-collide-with-bone does not silently override configuration of can-collide-with-tag (collision is on by default, afaik).

Example config

<per-vertex-shape name="VertexOfWoe">
    <margin>0.1</margin>
    <shared>internal</shared>
    <tag>hair</tag>
    <no-collide-with-tag>explosive_nipple</no-collide-with-tag>
    <can-collide-with-bone>NPC L Bone [LBon]</can-collide-with-bone>
    <can-collide-with-tag>body</can-collide-with-tag> <!-- ignored -->
    <can-collide-with-tag>ground</can-collide-with-tag> <!-- ignored -->
</per-vertex-shape>
@webspam
Copy link
Author

webspam commented Jan 28, 2023

no-collide-with-* is completely ignored if any entries in their respective can-collide-with-* have been added. Setting one can-* is equivalent to setting no-* on literally everything else.

@DaymareOn DaymareOn self-assigned this Apr 5, 2023
@DaymareOn DaymareOn added the bug Something isn't working label Apr 5, 2023
@sm644
Copy link

sm644 commented May 6, 2023

Not just bones. Using the latest version, I find that can-collide-with-tag stops all collisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants