Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to remove certain recipe via a MineTweaker-Addon? #763

Closed
3TUSK opened this issue Apr 13, 2015 · 14 comments
Closed

Is it possible to remove certain recipe via a MineTweaker-Addon? #763

3TUSK opened this issue Apr 13, 2015 · 14 comments

Comments

@3TUSK
Copy link

3TUSK commented Apr 13, 2015

Sorry for bothering you. Currently I am working on a TFCraft-MineTweaker3 cross-mod which allow modpack creator to add some custom recipes in TFC quern, anvil, barrel and etc.

While I am writing code I notice that it seems possible to remove some quern recipe by removing the recipe from List (also remove the itemstack from List vaildItem).
I am not sure whether TFCraft has such a rule that anyone cannot tweak the recipe because it can break the tech-tree, or the whold "system". Same thing appears on kiln and barrel.

Since I cannot figure out, then I decide to open this issue.
Thanks for your time, and I hope I'll get answer soon. Also I am sorry for poor English.

@Kittychanley
Copy link
Collaborator

We have our own recipe registry for quern recipes. It is currently not possible to remove or add to them without creating an addon, since Minetweaker can only remove recipes from the crafting recipe registry, not the quern recipe registry. If you'd like this functionality, you'll need to contact somebody over at modtweaker to add TFC compatibility.

@3TUSK
Copy link
Author

3TUSK commented Apr 13, 2015

Seems I didn't say it clearly...
Well, I made an add-on mod to allow MineTweaker to add or remove quern recipe. Currently situation is that I can add new quern recipe, but the remove function doesn't work.

@Kittychanley
Copy link
Collaborator

You realize that there is already something called modtweaker that you are supposed to use for Minetweaker functionality on non-vanilla things right?

@3TUSK
Copy link
Author

3TUSK commented Apr 13, 2015

But the thing is that There is no support for TFCraft in ModTweaker2.
ModTweaker2: https://github.com/jaredlll08/ModTweaker2

@Kittychanley
Copy link
Collaborator

Right. But it's open source. So fork it and add support.

@3TUSK
Copy link
Author

3TUSK commented Apr 13, 2015

Sorry, but You misunderstand my point.
The thing is, there are some mod that not allow MineTweaker to edit their recipe, like all Reika's MOD, due to the tech-tree problem.
I want to make sure that TFCraft doesn't have such a rule, before I do so.

@Kittychanley
Copy link
Collaborator

TFCraft does not have any rules against editing recipes. If you can find the cause of your inability to remove a recipe, we will happily fix it.

@3TUSK
Copy link
Author

3TUSK commented Apr 13, 2015

Okay, thanks for your time again.

@3TUSK 3TUSK closed this as completed Apr 13, 2015
@Yulife
Copy link

Yulife commented Apr 13, 2015

Sorry if I'm late to the conversation but not every minetweaker mod support is handled by Modtweaker. Some mods even include Minetweaker support in their mod natively but that requires constant pull requests if the author of the support isn't staff of the mod (repo). There are also seperate mods for Modtweaker support like Gregtech 6 Support.

@3TUSK I am the documenter of Modtweaker but hit me up when you got TFC support finished so I can document it ;)

@3TUSK
Copy link
Author

3TUSK commented Apr 13, 2015

@Yulife
My initial idea is making a individual mod to provide MineTweaker support for TFCraft, since I have been working on a modpack including GregTech5 and TFCraft at the same time for couples of weeks, and the tech-tree issue confused me a lot. Then I did it, which seems work well.

Thanks to the conversation, I realized that it will be a better idea that integrate this small mod into ModTweaker2, which might be much helpful for modpack creator.

Currently my school is a little bit busy, but I will save time to finish the integration ASAP. If you'd like to do documentation of that, I will say appreciate to you.
If there is grammatical mistakes, forgive me please.

@Yulife
Copy link

Yulife commented Apr 13, 2015

Your English is fine and readable! :) Looking forward to it.

@3TUSK
Copy link
Author

3TUSK commented Apr 14, 2015

@Yulife Which ModTweaker is latest? ModTweaker2 or ModTweaker-2?

@Yulife
Copy link

Yulife commented Apr 14, 2015

@3TUSK Modtweaker2 is a from-jared-continued version as joshiejack quit Modtweaker. Modtweaker-2 is a rewritten version of Modtweaker1. You may want to add integration into Modtweaker-2. :)

@Yulife
Copy link

Yulife commented Apr 14, 2015

Oops, please PR to Modtweaker2 repo, the non rewritten version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants