Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RED.events warning persist.js #11

Open
NietGiftig opened this issue Oct 17, 2020 · 17 comments
Open

RED.events warning persist.js #11

NietGiftig opened this issue Oct 17, 2020 · 17 comments

Comments

@NietGiftig
Copy link

Updated Node-red to 1.2.1, updated all nodes with update message showing.
When I do a deploy I get now always 2 warnings in the debug screen.
"[RED.events] Deprecated use of "nodes-started" event from "/home/pi/.node-red/node_modules/node-red-contrib-persist/persist.js:164:20". Use "flows:started" instead."

@nicedevil007
Copy link

Same here, any suggestions / fixes?

@sniicker
Copy link

Same here, pls help

@sniicker
Copy link

sniicker commented Oct 22, 2020

did anyone try a earlier version?

I tried Version 1.0.1 - 1.1.1

The same on all versions
My NodeRed Version is 1.2.2

@sniicker
Copy link

sniicker commented Oct 22, 2020

There is a little workaround.

  • go to the folder where the package is installed
    for me ( .....node-red\node_modules\node-red-contrib-persist
  • Make a copy of the File persist.js and give it another name
  • open the original file and search for "nodes-started" and replace it with "flows:started"

Restart NodeRED and see there is no error any more

Pls @DeanCording check your Code THX

Nice Greatings

@sniicker
Copy link

But this is another info i get:
(node:15184) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 flows:started listeners added to [EventEmitter]. Use emitter.setMaxListeners() to increase limit

this info comes with or without the above workaround.

@philosoma
Copy link

  • open the original file and search for "nodes-started" and replace it with "flows:started"

I've done this, error goes away, but it causes the charts to go wrong and become empty.

@sniicker
Copy link

@DeanCording pls help

@emc02
Copy link

emc02 commented Nov 10, 2020

got the warning too, please fix this with next version!
Everything else works perfect for me! Thanks for that!

@Paul-Reed
Copy link

There are 2 nodes-started that need changing to flows-started, then it works ok.

persist

@agenteDserrano
Copy link

same here

@bikeymouse
Copy link

I also ran into this error and confirm that the fix works, so thanks for the workaround!
@DeanCording / @ StephanStS : it has been some while since a last update ;-) Perhaps this can be included?

@UNOPARATOR
Copy link

Just created a PR ( #12 ) for this issue.

@bikeymouse
Copy link

Thanks, great!

Just a check: I see that you replaced "nodes_started" to "flows-started" in the code, although the fix mentioned here replaces this with "flows:started". Is both correct?

@UNOPARATOR
Copy link

UNOPARATOR commented May 3, 2021

Thanks, great!

Just a check: I see that you replaced "nodes_started" to "flows-started" in the code, although the fix mentioned here replaces this with "flows:started". Is both correct?

I guess you're right, I mistakenly made my changes based on @Paul-Reed's comment, but now that you mentioned it, previous comments state the same as what you mentioned above. I'll check and update my PR accordingly. But we'll never know if it will ever be merged ;)

Edit: Just updated my PR, thanks to @bikeymouse for his/her eagle eyes. 🥇

@arnljot
Copy link

arnljot commented Oct 18, 2021

There is a little workaround.

This is not a workaround. This is the fix for the deprecated API usage in the component. You should make a pull request with this fix.

@UNOPARATOR
Copy link

There is a little workaround.

This is not a workaround. This is the fix for the deprecated API usage in the component. You should make a pull request with this fix.

It has been waiting to be merged since May, 3rd: #12

@rhurup
Copy link

rhurup commented Feb 28, 2022

Updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests