Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced deprecated openapi_prefix for root_path. #22

Merged
merged 1 commit into from Feb 8, 2021
Merged

Replaced deprecated openapi_prefix for root_path. #22

merged 1 commit into from Feb 8, 2021

Conversation

synchronizing
Copy link
Contributor

@synchronizing synchronizing commented Oct 26, 2020

Fixes the following annoying warning:

"openapi_prefix" has been deprecated in favor of "root_path", which follows more closely the ASGI standard, is simpler, and more automatic. Check the docs at https://fastapi.tiangolo.com/advanced/sub-applications/

Fixes #13.

@synchronizing
Copy link
Contributor Author

@DeanWay If you don't mind to take a quick look at this, it would be appreciated. Small bug fix, and a simple one line changer.

@DeanWay DeanWay merged commit d96db33 into DeanWay:master Feb 8, 2021
@DeanWay
Copy link
Owner

DeanWay commented Feb 8, 2021

@synchronizing Thanks fo your PR, looks like this will need an accompanying change of requiring fastapi >= 0.56.0. As that appears to be the version where root_path was introduced

@DeanWay
Copy link
Owner

DeanWay commented Feb 8, 2021

I will apply that, and create a release for this

@DeanWay DeanWay mentioned this pull request Feb 8, 2021
@DeanWay
Copy link
Owner

DeanWay commented Feb 8, 2021

@synchronizing this is released in version 0.6.0

@synchronizing
Copy link
Contributor Author

@DeanWay Thank you for taking your time, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning: "openapi_prefix" has been deprecated in favor of "root_path"
2 participants