Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

[BUG] Toast shows incorrect mod count (race condition) #108

Closed
Hexcede opened this issue Dec 3, 2021 · 2 comments · Fixed by #112
Closed

[BUG] Toast shows incorrect mod count (race condition) #108

Hexcede opened this issue Dec 3, 2021 · 2 comments · Fixed by #112
Assignees
@DeathsGun
Labels
bug Something isn't working waiting for fix confirmation This issue has been fixed but waits for the confirmation of the issue owner
Projects
Bugs
Milestone
1.2.1+1.17-alpha

Comments

@Hexcede
Copy link

Hexcede commented Dec 3, 2021 •
edited
Loading

Describe the bug
When loading the game, the toast can display before all mods have actually been checked for updates. This results in the toast showing an incorrect number of mods (e.g. 3), but when entering the menu there are actually more (e.g. 13, I have a lot of mods that don't respect semver apparently).

To Reproduce
Steps to reproduce the behavior:

  1. Install a few mods which don't respect semver or have multiple out of date mods
  2. Launch the game so that the toast will display
  3. Sometimes the correct count is displayed but usually if the game window is focused it will pop up immediately with an incorrect count

Expected behavior
The toast displays the correct number of mods.

Screenshots
Incorrect number of mods displayed:
image

Outdated mods in manager (There are 13):
image

Please complete the following information:

  • OS: Linux (KDE + Ubuntu)
  • Minecraft version: 1.17.1
  • Version: 1.2.0
@Hexcede Hexcede added the bug Something isn't working label Dec 3, 2021
@DeathsGun
Copy link
Member

Yeah I noticed that one too but haven't had time to track it down
Thank you for finding the reason for that one

@DeathsGun DeathsGun added this to To do in Bugs via automation Dec 3, 2021
@DeathsGun DeathsGun added this to the 1.2.1+1.17-alpha milestone Dec 3, 2021
DeathsGun added a commit that referenced this issue Dec 5, 2021
@DeathsGun
Wait for all update check taks to be completed
f0dfb26 
Closes #108
DeathsGun added a commit that referenced this issue Dec 5, 2021
@DeathsGun
Improve update checking
1c6a3d5 
- Move update checking to preLaunch
- Show toast only when finished

Closes #108

Signed-off-by: DeathsGun <deathsgun@protonmail.com>
@DeathsGun DeathsGun mentioned this issue Dec 5, 2021
Merged
@DeathsGun
Copy link
Member

This should fix your problem:
modmanager-1.2.0-alpha+1.17.jar.zip

@DeathsGun DeathsGun moved this from To do to In progress in Bugs Dec 5, 2021
@DeathsGun DeathsGun added the waiting for fix confirmation This issue has been fixed but waits for the confirmation of the issue owner label Dec 5, 2021
Bugs automation moved this from In progress to Done Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DeathsGun DeathsGun

Labels
bug Something isn't working waiting for fix confirmation This issue has been fixed but waits for the confirmation of the issue owner
Projects
No open projects
Bugs
Done
Milestone
1.2.1+1.17-alpha
Development

Successfully merging a pull request may close this issue.

Improve update checking ModManagerMC/ModManager
2 participants
@Hexcede @DeathsGun