Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

Showing updates for mods that i don't have in my mods #18

Closed
kuzeeeyk opened this issue Aug 24, 2021 · 6 comments · Fixed by #26
Closed

Showing updates for mods that i don't have in my mods #18

kuzeeeyk opened this issue Aug 24, 2021 · 6 comments · Fixed by #26
Labels
bug Something isn't working
Milestone
1.0.1-alpha

Comments

@kuzeeeyk
Copy link
Contributor

kuzeeeyk commented Aug 24, 2021 •
edited
Loading

I guess it happens because of search system of modmanager, it show Litematica as addon of Litematica (GrabcraftLitematic)
image
@kuzeeeyk kuzeeeyk added the bug Something isn't working label Aug 24, 2021
@DeathsGun DeathsGun added the log missing Log for this issue is missing label Aug 24, 2021
@DeathsGun
Copy link
Member

Can i have your log?

@kuzeeeyk
Copy link
Contributor Author

latest.log
also when i click to update button on these type of mods (that i dont have), it says couldnt find jar for x

@DeathsGun
Copy link
Member

Ah it shows up because GrabcraftLitematic is the only litematica mod on modrinth
I need to change the update system to a clearer one.

@DeathsGun DeathsGun removed the log missing Log for this issue is missing label Aug 24, 2021
@DeathsGun DeathsGun added this to the 1.0.1-alpha milestone Aug 24, 2021
DeathsGun added a commit that referenced this issue Aug 24, 2021
@DeathsGun
Get modrinth id by first getting the mod by the fabric id
99b9eba 
Closes #18

Signed-off-by: DeathsGun <deathsgun@protonmail.com>
@DeathsGun DeathsGun mentioned this issue Aug 24, 2021
Merged
@DeathsGun
Copy link
Member

Can you check this again with this version:
Artifacts.zip

@DeathsGun DeathsGun added the waiting for fix confirmation This issue has been fixed but waits for the confirmation of the issue owner label Aug 24, 2021
@kuzeeeyk
Copy link
Contributor Author

fixed. probably... that build fixed this problem but i have very similar problem so i'll write this to here

image

i dont have this mods too but diffirent side of them is giving me error while trying to update:
image

@DeathsGun
Copy link
Member

ah libzoomer is probably part of OkZoomer think the detection of mods in mods isn't working correctly in some cases

@DeathsGun DeathsGun removed the waiting for fix confirmation This issue has been fixed but waits for the confirmation of the issue owner label Aug 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.1-alpha
Development

Successfully merging a pull request may close this issue.

Get modrinth id by first getting the mod by the fabric id ModManagerMC/ModManager
2 participants
@DeathsGun @kuzeeeyk