Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugs / questions #9

Closed
6 tasks done
drikssy opened this issue Sep 29, 2022 · 3 comments
Closed
6 tasks done

bugs / questions #9

drikssy opened this issue Sep 29, 2022 · 3 comments

Comments

@drikssy
Copy link
Member

drikssy commented Sep 29, 2022

@yuliu-debond we need to address the following queries.

Debond-token

  • test mintAllocatedToken rigorously, the test doesn't take into consideration the allocated supply.
  • Also about the mintCollateralized functionality, how it works, whether there needs to be vesting etc.
  • how to balance DGOV for the allocation of investors

VVIMP:

  • explain the different mathematical formulas about the debond token functionality.
  • there is no contract logic that wants to recover the vesting.
  • also the getLockedBalance, there is 5% of maxLocked supply that can be transferred, why is that fixed?
    some external queries
  • what supply will be stored if DGOV is minted in centralized exchange? thanks .
@dhruvmalik007
Copy link

  • need to explain the lockable supply and collateralised supply .

@dhruvmalik007
Copy link

regarding the centralised-exchange:

  • we need to mint directly the tokens for the exchanges (without effecting the other supplies).

@dhruvmalik007
Copy link

dhruvmalik007 commented Sep 30, 2022

regarding checking allocationSupply:

  • its checked in both debond-governance and token, thus we need to remove one implementation for gas efficiency.

regarding the dgov supply for exchange

  • need to integrate function to mint supply for exchanges .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants