Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(typography): adding body caption and footnote bold text styles #65

Merged
merged 3 commits into from Jun 23, 2022
Merged

feat(typography): adding body caption and footnote bold text styles #65

merged 3 commits into from Jun 23, 2022

Conversation

florentlotthepro
Copy link
Contributor

@florentlotthepro florentlotthepro commented Jun 2, 2022 •
edited

Changes description

Add missing text styles.

Context

We do a check of the showcase and see that there is some missing text styles.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on an iPhone device/simulator.
  • If it includes design changes, please ask for a review with a core team designer.

Does this introduce a breaking change?

  • No

Screenshots

iPhone

UIKit

Simulator Screen Shot - iPhone 11 - 2022-06-02 at 16 00 59

SwiftUI

Simulator Screen Shot - iPhone 11 - 2022-06-02 at 16 01 23

Other information

@florentlotthepro florentlotthepro requested a review from a team June 2, 2022 15:20
@florentlotthepro florentlotthepro force-pushed the feat/typography_new_text_styles branch from e573ef5 to 9400482 Compare June 2, 2022 15:23
@florentlotthepro florentlotthepro added design request 🙌 Ready for Design Review The showcase is ready for design review labels Jun 2, 2022
daniel-dumortier
daniel-dumortier requested changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@daniel-dumortier daniel-dumortier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the VitaminTextStyle.init?(rawValue: String) should be updated to handle the three new text styles (to be able to use them directly in storyboards, as mentioned by the comment above the method)
Otherwise, everything seems ok for me.

@florentlotthepro
Copy link
Contributor Author

Oh yes, I forgot that, thanks!

baptistedajon
baptistedajon approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@baptistedajon baptistedajon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@florentlotthepro florentlotthepro added design request 🙌 and removed design request 🙌 Ready for Design Review The showcase is ready for design review labels Jun 23, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@florentlotthepro florentlotthepro merged commit 30e8197 into main Jun 23, 2022
@florentlotthepro florentlotthepro deleted the feat/typography_new_text_styles branch June 23, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baptistedajon baptistedajon baptistedajon approved these changes

@daniel-dumortier daniel-dumortier daniel-dumortier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@florentlotthepro @baptistedajon @daniel-dumortier