New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(button): VitaminButton swiftUI implementation #76
Conversation
ec149a3
to
62c523d
Compare
I decided to commit an intermediate solution for the problem of reusing
With this approach, I think we combine two advantages :
Any feedbacks on this approach (and if it is better than the previous) are welcome ;) |
… strategy (composition vs buttonStyle)
420de21
to
001330d
Compare
…tor code in smaller methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍
Just a few comments.
Showcase/Application/SwiftUI/Components/Button/ButtonsView.swift
Outdated
Show resolved
Hide resolved
Showcase/Application/SwiftUI/Components/Button/ButtonsView.swift
Outdated
Show resolved
Hide resolved
Showcase/Application/SwiftUI/Components/Button/ButtonsView.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Florent LOTTHÉ <florent.lotthe@decathlon.com>
Co-authored-by: Florent LOTTHÉ <florent.lotthe@decathlon.com>
480d61d
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Changes description
this PR aims to provide a Swift UI implementation for VitaminButton.
It is still in draft, because some points are to be finalized or discussed
Context
related issue still to be created
Checklist
Does this introduce a breaking change?
Screenshots
I will add screenshots when finalized
iPhone
iPad
Other information
For now, the base branch is the UIKit VitaminButton icon alone branch, will change to develop once validated and merged