feat: added additional prop checked to checkbox #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaitmore
suggested changes
Jul 11, 2019
There was a problem hiding this comment.
This was my bad, I moved {...props} from line 26 to line 20.
I think it's ok to be explicit about passing the checked prop, but could you also revert my change by adding {...props} back to the CheckBox component to avoid future problems? And could you also add a style prop that is passed to InputWrap? Thank you!!
tilleryd
pushed a commit
that referenced
this pull request
Jul 14, 2019
* feat: added additional prop checked to checkbox * feat: passing all props to checkbox * chore: resolved linting errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is necessary to be able to set checkboxes as controlled components