Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Subset class imported from torch.utils.data isn't Configurable #85

Closed
Oxer11 opened this issue Apr 3, 2022 · 1 comment
Closed

The Subset class imported from torch.utils.data isn't Configurable #85

Oxer11 opened this issue Apr 3, 2022 · 1 comment

Comments

@Oxer11
Copy link
Contributor

Oxer11 commented Apr 3, 2022

In patch.py, we manually modify all datasets in the torch.utils.data.dataset to make it configurable. However, the line below only sets the attributes of torch.utils.data.dataset not torch.utils.data, which leaves all Dataset imported from the latter unchanged. There is a similar problem for torch.optim.lr_scheduler.

torchdrug/torchdrug/patch.py

Line 156 in 119002a

setattr(dataset, name, cls)

@KiddoZhu
Copy link
Contributor

KiddoZhu commented Apr 3, 2022

Fixed in f29dc55

@KiddoZhu KiddoZhu closed this as completed Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KiddoZhu @Oxer11