New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complex product should be used in eltwise product #3
Comments
Many thanks for your advice! I will investigate into that later! |
After some doc rushing I think |
from my tests, it's the complex product that matches the original Caffe version very roughly based on your code, i made a version that uses new PyTorch fft support: https://gist.github.com/vadimkantorov/d9b56f9b85f1f4ce59ffecf893a1581a |
Awesome! I'll check the caffe version later. |
a link to original author's caffe impl (complex product): https://github.com/gy20073/compact_bilinear_pooling/blob/master/caffe-20160312/src/caffe/layers/compact_bilinear_layer.cpp#L219 if |
Checked the original paper again. Although the paper doesn't make an explicit statement, I believe u r right. It makes more sense for element-wise complex product than naive production. Many thanks for your help! I'll update this repo soon. |
I was investigating differences in results of this package and of the original Caffe version. Things found so far:
output_dim
in order to achieve full equivalence with original caffe versionThe text was updated successfully, but these errors were encountered: