Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

properly set up matrix os for CI #22

Closed
Remi-Gau opened this issue Jul 30, 2022 · 0 comments · Fixed by #30
Closed

properly set up matrix os for CI #22

Remi-Gau opened this issue Jul 30, 2022 · 0 comments · Fixed by #30

Comments

@Remi-Gau
Copy link
Collaborator

Tackle after merging of #18

the other errors came either from changing v2->v3 or from matrix os (I guess the latter).

yes most likely the latter because the way it is set up now, all tests are only run on Linux

See this workflow that is supposed to run on MacOS but actually ran on Ubuntu
https://github.com/DeepMReye/DeepMReye/runs/7576038296?check_suite_focus=true#step:1:3

So I would suggest merging this and fixing the CI for OS in another PR after that.

Originally posted by @Remi-Gau in #18 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MNT] test in with linux up to python 3.11 Remi-Gau/DeepMReye
1 participant
@Remi-Gau