Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] fix dockerfile and add a dockerfile for dev #32

Merged
merged 3 commits into from Jan 11, 2023

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Dec 28, 2022

related to #31

  • Dockerfile will use deepmreye from pypi
  • dev Dockerfile will use the local version of pypi
  • update default model to use in docker and notebooks

@Remi-Gau Remi-Gau merged commit ff76157 into DeepMReye:main Jan 11, 2023
@CYHSM
Copy link
Contributor

CYHSM commented Jan 12, 2023

I can add the circle-ci integration, which is needed to test the docker image I assume?
Edit: https://app.circleci.com/pipelines/github/DeepMReye/DeepMReye

@Remi-Gau
Copy link
Collaborator Author

awesome
thanks

yeah the build passes that is what I expected

for the deploy to work we would need to:

  • have a dockerhub account to push the image to
  • let circleci push that docker hub (by adding a dockerhub token to the context of circle ci)

FYI: new tagged release of the package would push a tagged image and a new "latest" version to docker hub. Untagged commit to the default branch would push an image called "unstable" on docker hub

This is the strategy used by fmriprep from what I understand.

@CYHSM
Copy link
Contributor

CYHSM commented Jan 12, 2023

Nice, that sounds perfect. I put in both DOCKER_TOKEN and DOCKER_USER but still seems to fail with exit code 1
Do I also need to set CIRCLE_PROJECT_USERNAME? And is there any way of getting more info from circle-ci?

Edit: Got the Token error fixed but now the access seems to be denied: https://app.circleci.com/pipelines/github/DeepMReye/DeepMReye/1/workflows/be3cf23e-17d0-44a8-b691-b68a35d75ecd/jobs/5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants