Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add liquid state optimizations via sample_state attribute of ConfigSimulator #267

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mgiammar
Copy link
Collaborator

@mgiammar mgiammar commented Jun 6, 2023

Addresses #211

  • Update changelog
  • Include sample_state in relevant documentation examples
  • Cover new code with pytest

@mgiammar mgiammar self-assigned this Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 99.89%. Comparing base (545e4dd) to head (e9705b8).
Report is 18 commits behind head on master.

❗ Current head e9705b8 differs from pull request most recent head 81c5b0b. Consider uploading reports for the commit 81c5b0b to get more accurate results

Files Patch % Lines
src/mrsimulator/simulator/__init__.py 33.33% 6 Missing ⚠️
src/mrsimulator/simulator/config.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
+ Coverage   99.32%   99.89%   +0.56%     
==========================================
  Files         120      112       -8     
  Lines        8330     7297    -1033     
==========================================
- Hits         8274     7289     -985     
+ Misses         56        8      -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgiammar mgiammar marked this pull request as draft June 19, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants