Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extras.py is still present on version 2.0.0 #97

Closed
azhpushkin opened this issue Nov 15, 2019 · 5 comments
Closed

extras.py is still present on version 2.0.0 #97

azhpushkin opened this issue Nov 15, 2019 · 5 comments

Comments

@azhpushkin
Copy link

Steps to reproduce: install latest version from pypi

image

There is no extras.py in source code anymore but it is still present after installation. This creates certain confusion as two versions of KeysSubset are present (in keys.py and extras).
Moreover, documentation is still pointing to the extras, which is even more confusing

@azhpushkin
Copy link
Author

@Deepwalker This is not urgent at all, but I guess you are the only one who can update the build 🤞

@Arfey
Copy link
Collaborator

Arfey commented Nov 15, 2019

thx for your contribution. MR u welcome.

@sonerayberk
Copy link
Contributor

@Arfey I'm afraid, but isn't the build can be built and deployed to PyPI by the author of the library?

@Arfey
Copy link
Collaborator

Arfey commented Nov 15, 2019

Sure, but will be great if u fix documentation :)

@Deepwalker
Copy link
Owner

Have no idea how it happened. Issued 2.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants