Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chart-js-rails gem #379

Merged
merged 1 commit into from Jun 30, 2016
Merged

Remove chart-js-rails gem #379

merged 1 commit into from Jun 30, 2016

Conversation

ghost
Copy link

@ghost ghost commented Mar 5, 2016

I removed chart-js-rails gem the following reasons.

  • Same role gem has been used(chart-js-rails gem and rails-assets-chartjs gem).
  • chart-js-rails gem is not used on current source code.
  • Rails Assets team have migration plan. Please see here.

Thank you.

@@ -7,7 +7,6 @@
//= require pikaday
//= require chartjs
//= require select2
//= require charts
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chart-js-rails(0.0.6) needs to require //= require Chart.
Please see here.

@jurre
Copy link
Contributor

jurre commented Jun 14, 2016

👍

@fatboypunk fatboypunk merged commit ed6a452 into DefactoSoftware:development Jun 30, 2016
@ghost ghost deleted the remove-chart-js-rails branch July 1, 2016 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants