[@types/jsdom] ConstructorOptions -> BaseOptions -> contentType is too restrictive

[CodingDoug]

The constructor options property is declared like this:

contentType?: SupportedContentTypes | undefined;

    type SupportedContentTypes =
        | "text/html"
        | "application/xhtml+xml"
        | "application/xml"
        | "text/xml"
        | "image/svg+xml";

This means that contentType must only be one of the acceptable strings. However, this is too restrictive. The contentType attribute can also take a charset along with it (e.g. text/html; charset=utf-8). JSDOM observes this charset correctly, and is even documented as such (emphasis mine):

contentType affects the value read from document.contentType, as well as how the document is parsed: as HTML or as XML. Values that are not a HTML MIME type or an XML MIME type will throw. It defaults to "text/html". If a charset parameter is present, it can affect binary data processing.

My use cases requires that I provide a charset. Right now, I have to play games with TypeScript to get it to accept my string which is unknown at compile time (since it comes from an HTTP header).

I think contentType should accept any string, and the caller should accept that JSDOM will throw (as documented above) if it's not supported.

[typescript-bot]

Thanks for the discussion about "jsdom", some useful links for everyone:

• npm
• DT
• Related discussions

Pinging the DT module owners: @leonard-thieu, @palmfjord, @ExE-Boss.

[ghost]

Created #69520 to fix this