[markdownlint-rule-helpers] tokens
property removed from RuleParams in markdownlint 0.34.0
#69627
Unanswered
rsese
asked this question in
Issues with a @types package
Replies: 2 comments 3 replies
-
Thanks for the discussion about "markdownlint-rule-helpers", some useful links for everyone: Pinging the DT module owners: @JoshuaKGoldberg. |
Beta Was this translation helpful? Give feedback.
2 replies
-
What if the developer using |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
👋 ! Was having some trouble using the types for markdownlint and markdownlint-rule-helpers where a custom rule we have that uses the
filterTokens()
function:https://github.com/DavidAnson/markdownlint/blob/b2305efafb034b1f328845aec9928b5363ffd646/helpers/helpers.js#L347
Had a type error saying
Property 'tokens' is missing
in the first argumentparams
which is a RuleParams object:https://github.com/DavidAnson/markdownlint/blob/b2305efafb034b1f328845aec9928b5363ffd646/lib/markdownlint.d.ts#L114-L135
From my poking I found as part of v0.34.0, in DavidAnson/markdownlint@c44f165#diff-bb0111f3d75d5332283370198902c51b2df5924e43692ea7b2e2b64b9cb34acd the
tokens
property was removed fromRuleParams
.But the version of markdownlint used for the types here specifies
^0.30.0
:https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/markdownlint-rule-helpers/package.json#L11
Was going to open a PR to bump the version:
But still new-ish to TS and the types in this repo so figured I would ask here first -- thanks 🙇 !
Beta Was this translation helpful? Give feedback.
All reactions