Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TypeScript 2.0 #10072

Closed
use-strict opened this issue Jul 12, 2016 · 12 comments
Closed

Support TypeScript 2.0 #10072

use-strict opened this issue Jul 12, 2016 · 12 comments

Comments

@use-strict
Copy link
Contributor

TypeScript 2.0 beta is up on npm. @vvakame, @basarat , I'll want to update some typings for jQuery but I need tsc 2.0 support first. Do you know what exactly has to be done for this to work?

A big problem also is about breaking changes. Function 'this' types, in conjunction with 'noImplicitThis', will lead to definitions that will be incompatible with older compiler versions. There are probably other backwards-incompatible changes, like patterns in module declarations.

@mhegazy
Copy link
Contributor

mhegazy commented Jul 12, 2016

The TS-2.0 specific declarations are in types-2.0 branch. feel free to send PRs against that branch. also worth noting that this branch is where the @types packages get published from.

We intend to merge the types-2.0 branch into master a few weeks after the final TS 2.0 release.

@use-strict
Copy link
Contributor Author

Great, thanks. I'll have a go at it tomorrow.

@use-strict
Copy link
Contributor Author

use-strict commented Jul 13, 2016

Looks like that branch is using tsc 1.8 as well. Maybe I'm doing something wrong. I ran npm install followed by npm test.

@use-strict
Copy link
Contributor Author

@mhegazy , looks like the npm-shrinkwrap.json file is not consistent with package.json. It should be regenerated.

@use-strict
Copy link
Contributor Author

Removed devDependencies from shrinkwrap. #10092

@jleider
Copy link
Contributor

jleider commented Sep 15, 2016

I see the use-strict-jquery-ts2-this branch but those updates have not been merged into the types-2.0 branch. This would be great to get merged into the types-2.0 branch.

@e-cloud
Copy link
Contributor

e-cloud commented Oct 31, 2016

@mhegazy , there have been more than a few weeks from July. Is there a clear plan to merge types 2.0 into master?

@zakdances
Copy link

I'm unclear on this too - at this time, which branch should we be PR'ing?

@screendriver
Copy link
Contributor

Quote from the docs

New work should generally be done on the types-2.0 branch. If you want your changes to be available to typings users, then you may edit master instead.

@vvakame
Copy link
Member

vvakame commented Dec 20, 2016

It landed to master branch already. 😉

@vvakame vvakame closed this as completed Dec 20, 2016
@e-cloud
Copy link
Contributor

e-cloud commented Dec 20, 2016

So, should we now all commit PR on master rather than types-2.0?

@vvakame
Copy link
Member

vvakame commented Dec 20, 2016

@e-cloud I understand so. @DefinitelyTyped/contributors is this rights?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants